I like orcs the way they are in LotR and D&D. Evil, black-skinned, marauding, barbaric, evil creatures. Maybe an orc 'nation' of some sort but generally just smaller tribes that cause problems for local humans.
Warcraft orcs, and even Warhammer orcs, are a bit too organised and militaristic for my tastes. They're cool but not what I'd want in my ideal fantasy world. Orcs are monsters, not a race. (I hope that made sense..)
I like warcraft trolls a lot, especially since trolls in most fantasy fill the same niche as ogres. Big, scary, rawr. Having that separation is cool.
Everquest made trolls too civilised (by giving them towns and even a small city) while retaining their stupid/simplistic traits. It sort of contradicted itself, imo. They were still cool, but I think Warcraft trolls trump all because they're an entirely different and 'new' take on an old classic, with the voodoo jamaca type twist. Their goblins are similar.